[incubator-dolphinscheduler] 03/05: fix bug: sqoop mysql import params error (#2896)

[leonbao]

This is an automated email from the ASF dual-hosted git repository.

leonbao pushed a commit to branch 1.3.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git

commit 334b5cef889fef2f567936099cc1e842c51dadd9
Author: Yelli <amarant...@my.com>
AuthorDate: Fri Jun 5 10:32:35 2020 +0800

    fix bug: sqoop mysql import params error (#2896)
    
    * fix bug: sqoop mysql import params error
    
    * fix bug: sqoop mysql import params error
---
 .../sqoop/generator/sources/MysqlSourceGenerator.java  | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git 
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
 
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
index f8e3d57..8cd5357 100644
--- 
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
+++ 
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java
@@ -77,35 +77,35 @@ public class MysqlSourceGenerator implements 
ISourceGenerator {
                         }else{
                             srcQuery += " WHERE $CONDITIONS";
                         }
-                        result.append(" --query \'"+srcQuery+"\'");
+                        result.append(" --query 
\'").append(srcQuery).append("\'");
 
                     }
 
                     List<Property>  mapColumnHive = 
sourceMysqlParameter.getMapColumnHive();
 
                     if(mapColumnHive != null && !mapColumnHive.isEmpty()){
-                        String columnMap = "";
+                        StringBuilder columnMap = new StringBuilder();
                         for(Property item:mapColumnHive){
-                            columnMap = item.getProp()+"="+ 
item.getValue()+",";
+                            
columnMap.append(item.getProp()).append("=").append(item.getValue()).append(",");
                         }
 
-                        if(StringUtils.isNotEmpty(columnMap)){
+                        if(StringUtils.isNotEmpty(columnMap.toString())){
                             result.append(" --map-column-hive ")
-                                    
.append(columnMap.substring(0,columnMap.length()-1));
+                                    
.append(columnMap.substring(0,columnMap.length() - 1));
                         }
                     }
 
                     List<Property>  mapColumnJava = 
sourceMysqlParameter.getMapColumnJava();
 
                     if(mapColumnJava != null && !mapColumnJava.isEmpty()){
-                        String columnMap = "";
+                        StringBuilder columnMap = new StringBuilder();
                         for(Property item:mapColumnJava){
-                            columnMap = item.getProp()+"="+ 
item.getValue()+",";
+                            
columnMap.append(item.getProp()).append("=").append(item.getValue()).append(",");
                         }
 
-                        if(StringUtils.isNotEmpty(columnMap)){
+                        if(StringUtils.isNotEmpty(columnMap.toString())){
                             result.append(" --map-column-java ")
-                                    
.append(columnMap.substring(0,columnMap.length()-1));
+                                    
.append(columnMap.substring(0,columnMap.length() - 1));
                         }
                     }
                 }