CallMeKingsley97 commented on code in PR #14606:
URL:
https://github.com/apache/dolphinscheduler/pull/14606#discussion_r1270260583
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -784,6 +785,16 @@ public void checkSerialProcess(ProcessDefinition
processDefinition) {
return;
}
Map<String, Object> cmdParam = new HashMap<>();
+ // write the parameters of the nextProcessInstance to command
+ if (StringUtils.isNotEmpty(nextProcessInstance.getCommandParam())) {
+ Map<String, String> commandStartParamsMap =
JSONUtils.toMap(nextProcessInstance.getCommandParam());
+ if (MapUtils.isNotEmpty(commandStartParamsMap)) {
+ Map<String, String> paramsMap =
JSONUtils.toMap(commandStartParamsMap.get(CMD_PARAM_START_PARAMS));
+ if (MapUtils.isNotEmpty(paramsMap)) {
+ cmdParam.put(CMD_PARAM_START_PARAMS,
JSONUtils.toJsonString(paramsMap));
+ }
+ }
+ }
Review Comment:
> It should work, but it's better to change the command consumer logic
rather than put the param in wakeup command.
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
