EricGao888 commented on PR #14626: URL: https://github.com/apache/dolphinscheduler/pull/14626#issuecomment-1647425056
> > @ruanwenjun Hi, may I ask why you want to revert this change? > > This PR introduces some serious bugs. > > 1. In many drivers, the connection is not thread-safe, this pr hold one connection in CommonDataSourceClient, this will cause multiple tasks get the same connection at the same time. > 2. In many drivers, `connection.isClosed()` is only check the closed flag at the driver side, it cannot represent if the connection is active/valided. Got it, thx for the explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
