SbloodyS commented on code in PR #14629: URL: https://github.com/apache/dolphinscheduler/pull/14629#discussion_r1272096830
########## dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-voice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoidceParam.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.alert.voice; + +public class VoidceParam { + + /** + * called Number + */ + private String calledNumber; + /** + * called Show Number + */ + private String calledShowNumber; + /** + * tts code + */ + private String ttsCode; + /** + * tts param + */ + private String ttsParam; + + /** + * connection info + */ + private Connection connection; + + /** + * outId + */ + private String outId; + + public static class Connection { + + /** + * address + */ + private String address; + + /** + * accessKeyId + */ + private String accessKeyId; + /** + * accessKeySecret + */ + private String accessKeySecret; + + /** + * tts Code + */ + private String ttsCode; + + public String getAddress() { + return address; + } + + public void setAddress(String address) { + this.address = address; + } + + public String getAccessKeyId() { + return accessKeyId; + } + + public void setAccessKeyId(String accessKeyId) { + this.accessKeyId = accessKeyId; + } + + public String getAccessKeySecret() { + return accessKeySecret; + } + + public void setAccessKeySecret(String accessKeySecret) { + this.accessKeySecret = accessKeySecret; + } + + public String getTtsCode() { + return ttsCode; + } + + public void setTtsCode(String ttsCode) { + this.ttsCode = ttsCode; + } + } + + public String getCalledNumber() { + return calledNumber; + } + + public void setCalledNumber(String calledNumber) { + this.calledNumber = calledNumber; + } + + public String getCalledShowNumber() { + return calledShowNumber; + } + + public void setCalledShowNumber(String calledShowNumber) { + this.calledShowNumber = calledShowNumber; + } + + public String getTtsCode() { + return ttsCode; + } + + public void setTtsCode(String ttsCode) { + this.ttsCode = ttsCode; + } + + public String getTtsParam() { + return ttsParam; + } + + public void setTtsParam(String ttsParam) { + this.ttsParam = ttsParam; + } + + public Connection getConnection() { + return connection; + } + + public void setConnection(Connection connection) { + this.connection = connection; + } + + public String getOutId() { + return outId; + } + + public void setOutId(String outId) { + this.outId = outId; + } Review Comment: Please replace these with lombok `@Data`. ########## dolphinscheduler-ui/pnpm-lock.yaml: ########## @@ -1,20 +1,4 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. -lockfileVersion: 5.4 Review Comment: Why did you remove this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
