lgcareer commented on pull request #2832: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2832#issuecomment-640998600
> > > @lgcareer can you help review this? Thank you. Please explain if there is any problem. > > > > > > You can test use "/" before sid,such as jdbc:oracle:thin:@//:1521/SID,I think we didn't must use ":" before sid. > > Regarding the format of the URL, I am pretty sure that I will list it again. Before submitting this code, I used the local mode to run the API module test. Only the above three methods can pass. Regarding the question you mentioned, I conducted a query on Google again, and I did not find this way of using "/" to connect sid. It may be that the author's sid and service_name have the same name. > look forward to your reply. Thank you. If you test it and it can't work successful,I think you can use your code instead of I said,May be you are right,The last time I test successful is that the service_name and SID is consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
