ruanwenjun commented on code in PR #14612:
URL:
https://github.com/apache/dolphinscheduler/pull/14612#discussion_r1279380501
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Command.java:
##########
@@ -61,6 +61,7 @@ public class Command {
private String commandParam;
@TableField("task_depend_type")
+ @Builder.Default
Review Comment:
Please add `@Builer.Default` to `failureStrategy` and `updateTime`.
In fact I don't think it's a good idea to add default value in DO， but this
is a history issue.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Command.java:
##########
@@ -61,6 +61,7 @@ public class Command {
private String commandParam;
@TableField("task_depend_type")
+ @Builder.Default
Review Comment:
Please add `@Builer.Default` to `failureStrategy` and `updateTime`.
In fact I don't think it's a good idea to add default value in DO， but this
is a history issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
