qingwli commented on PR #14657: URL: https://github.com/apache/dolphinscheduler/pull/14657#issuecomment-1667549934
Hi @EricGao888 @SbloodyS @Radeity After talking with @Gallardot , I was in total misunderstanding, here is the deal: - 1. If you deployed ds using k8s and when you change values.yaml and use `helm upgrade` to update ds charts, but pods will not restart by auto, you need to do it manually. - 2. This pr will give pods the ability to monitor `configmap.yaml` and other yaml in the charts folder(we can add later), when you run `helm upgrade`, the helm will re-cal like the sign about the file and will restart the pods when touching the file changed. If the user deployed in the k8s model, this feature will be very useful, and if the user changes the configmap.yaml and the user definitely hope the pods will restart as expected. We always give users the option to enable this feature. So I'm +1 about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
