kezhenxu94 commented on code in PR #14803:
URL:
https://github.com/apache/dolphinscheduler/pull/14803#discussion_r1303862396
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types:
text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
> Will this configuration log `@RequestAttribute(value =
Constants.SESSION_USER) User loginUser`? Seems there are some credentials in
`User` object.
No, it logs the http request parameters, not the controller method's
arguments. Obviously credentials are not in the request parameters, they are in
headers
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types:
text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
> Will this configuration log `@RequestAttribute(value =
Constants.SESSION_USER) User loginUser`? Seems there are some credentials in
`User` object.
No, it logs the http request parameters, not the controller method's
arguments. Obviously credentials are not in the request parameters, they are in
http headers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
