[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #14815: [improvement] In order to achieve more Datax datasource type support

[via GitHub]

ruanwenjun commented on PR #14815:
URL: 
https://github.com/apache/dolphinscheduler/pull/14815#issuecomment-1697006904

   > hi @ruanwenjun @xinxingi I think it is best to write an abstract class to 
solve this problem, and use a public method for the jdbc type. Non-jdbc uses 
self-defined methods, the following are some optimizations of this method <img 
alt="image" width="988" 
src="https://user-images.githubusercontent.com/33984497/263637107-11965f4b-9e6b-4751-9a56-bc3e09b368c9.png";>
 <img alt="image" width="948" 
src="https://user-images.githubusercontent.com/33984497/263638427-1be67b50-d692-4090-9e81-ddfa9c97a952.png";>
   > 
   > cc @Radeity @SbloodyS
   
   Yes, this kind of logic should be put into a new interface, the DataXTask 
doesn't care about the content.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org