chenshuai1995 commented on code in PR #14910:
URL:
https://github.com/apache/dolphinscheduler/pull/14910#discussion_r1325535413
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java:
##########
@@ -410,6 +441,14 @@ public void sendProcessBlockingAlert(ProcessInstance
processInstance,
Alert alert = new Alert();
String cmdName = getCommandCnName(processInstance.getCommandType());
List<ProcessAlertContent> blockingNodeList = new ArrayList<>(1);
+
+ ProcessDefinitionLog processDefinitionLog = processDefinitionLogMapper
+
.queryByDefinitionCodeAndVersion(processInstance.getProcessDefinitionCode(),
+ processInstance.getProcessDefinitionVersion());
+ Map<Integer, String> userMap = userMapper.selectList(new
QueryWrapper<>()).stream()
Review Comment:
> May I ask Why use a map to store user information instead of querying
directly with user ID?
I have optimize, thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
