Radeity commented on code in PR #14934:
URL:
https://github.com/apache/dolphinscheduler/pull/14934#discussion_r1329602751
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java:
##########
@@ -257,6 +258,12 @@ private void parsePodLogOutput() {
try (BufferedReader reader = new BufferedReader(new
InputStreamReader(watcher.getOutput()))) {
while ((line = reader.readLine()) != null) {
log.info("[K8S-pod-log] {}", line);
+
+ if (line.contains(VarPoolUtils.VAR_PREFIX_DOLLAR)
+ ||
line.contains(VarPoolUtils.VAR_PREFIX_HASH)) {
+ varPool.append(VarPoolUtils.findVarPool(line));
+ varPool.append(VarPoolUtils.VAR_DELIMITER);
Review Comment:
Better add some doc about it, users don't declare `setValue` explicitly in
k8s task, they have to output `setValue` in pod logs. Another special
consideration, not always can we collect pod logs, if user redirect log output
stream, we can not collect logs use and can not use output parameter, either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
