ruanwenjun commented on code in PR #14929:
URL:
https://github.com/apache/dolphinscheduler/pull/14929#discussion_r1329475834
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java:
##########
@@ -66,6 +67,8 @@ public class DataSourceConstants {
public static final String VERTICA_VALIDATION_QUERY = "select 1";
public static final String HANA_VALIDATION_QUERY = "select 1";
+ public static final String XUGU_VALIDATION_QUERY = "select 1 from dual";
Review Comment:
Please move this in datasource plugin module.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java:
##########
@@ -43,6 +43,7 @@ public class DataSourceConstants {
public static final String NET_SNOWFLAKE_JDBC_DRIVER =
"net.snowflake.client.jdbc.SnowflakeDriver";
public static final String COM_VERTICA_JDBC_DRIVER =
"com.vertica.jdbc.Driver";
public static final String COM_HANA_DB_JDBC_DRIVER =
"com.sap.db.jdbc.Driver";
+ public static final String COM_XUGU_JDBC_DRIVER =
"com.xugu.xugu-jdbc.Driver";
Review Comment:
Please move this in datasource plugin module.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java:
##########
@@ -91,6 +94,7 @@ public class DataSourceConstants {
public static final String JDBC_SNOWFLAKE = "jdbc:snowflake://";
public static final String JDBC_VERTICA = "jdbc:vertica://";
public static final String JDBC_HANA = "jdbc:sap://";
+ public static final String JDBC_XUGU = "jdbc:xugu://";
Review Comment:
Please move this in datasource plugin module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
