Radeity commented on code in PR #14569:
URL:
https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337953378
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -825,6 +825,27 @@ private void initTaskQueue() throws
StateEventHandleException, CronParseExceptio
List<TaskInstance> validTaskInstanceList =
taskInstanceDao.queryValidTaskListByWorkflowInstanceId(workflowInstance.getId(),
workflowInstance.getTestFlag());
+ // the task instance needs fault tolerance
+ if(workflowInstance.getRecovery() == Flag.YES){
+ //determine whether the task is running
+ for (int i = 0; i < validTaskInstanceList.size(); i++) {
+ TaskInstance task = validTaskInstanceList.get(i);
+ boolean isRunningTaskFaultTolerance = false;
+ try {
+ isRunningTaskFaultTolerance =
determineWhetherTaskIsRunning(task);
Review Comment:
For example, Worker should know the master change, and send task result to
new Master. Have you tested this PR? In your implementation, task will not be
re-submitted, but state of running task will not be updated either?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
