Gallardot commented on code in PR #14972:
URL:
https://github.com/apache/dolphinscheduler/pull/14972#discussion_r1339790459
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-webexteams/src/main/java/org/apache/dolphinscheduler/plugin/alert/webexteams/WebexTeamsSender.java:
##########
@@ -67,16 +68,28 @@ public AlertResult sendWebexTeamsAlter(AlertData alertData)
{
alertResult.setStatus("false");
alertResult.setMessage("send webex teams alert fail.");
- try {
- send(alertResult, alertData);
- } catch (Exception e) {
- log.info("send webex teams alert exception : {}", e.getMessage());
+ for (int i = 0; i < AlertConstants.RETRY_TIMES; i++) {
Review Comment:
I'm voting -1. There is a bad code smell here, with some duplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
