github-code-scanning[bot] commented on code in PR #14991:
URL:
https://github.com/apache/dolphinscheduler/pull/14991#discussion_r1349620956
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java:
##########
@@ -133,27 +127,21 @@
*
* @param loginUser
* @param userName owner
- * @param limitsCpu max cpu
- * @param limitsMemory max memory
* @return
*/
@Operation(summary = "updateK8sNamespace", description =
"UPDATE_NAMESPACE_NOTES")
@Parameters({
@Parameter(name = "id", description = "K8S_NAMESPACE_ID", required
= true, schema = @Schema(implementation = int.class, example = "100")),
- @Parameter(name = "userName", description = "OWNER", required =
false, schema = @Schema(implementation = String.class)),
- @Parameter(name = "limitsCpu", description = "LIMITS_CPU",
required = false, schema = @Schema(implementation = double.class)),
- @Parameter(name = "limitsMemory", description = "LIMITS_MEMORY",
required = false, schema = @Schema(implementation = int.class))})
+ @Parameter(name = "userName", description = "OWNER", required =
false, schema = @Schema(implementation = String.class))})
@PutMapping(value = "/{id}")
@ResponseStatus(HttpStatus.CREATED)
@ApiException(UPDATE_K8S_NAMESPACE_ERROR)
public Result updateNamespace(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@PathVariable(value = "id") int id,
@RequestParam(value = "userName", required =
false) String userName,
- @RequestParam(value = "tag", required =
false) String tag,
- @RequestParam(value = "limitsCpu", required
= false) Double limitsCpu,
- @RequestParam(value = "limitsMemory",
required = false) Integer limitsMemory) {
+ @RequestParam(value = "tag", required =
false) String tag) {
Review Comment:
## Useless parameter
The parameter 'tag' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3505)
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/K8sNamespaceService.java:
##########
@@ -46,24 +46,18 @@
* @param loginUser login user
* @param namespace namespace
* @param clusterCode k8s not null
- * @param limitsCpu limits cpu, can null means not limit
- * @param limitsMemory limits memory, can null means not limit
* @return
*/
- Map<String, Object> createK8sNamespace(User loginUser, String namespace,
Long clusterCode, Double limitsCpu,
- Integer limitsMemory);
+ Map<String, Object> createK8sNamespace(User loginUser, String namespace,
Long clusterCode);
/**
* update K8s Namespace tag and resource limit
*
* @param loginUser login user
* @param userName owner
- * @param limitsCpu max cpu
- * @param limitsMemory max memory
* @return
*/
- Map<String, Object> updateK8sNamespace(User loginUser, int id, String
userName, Double limitsCpu,
- Integer limitsMemory);
+ Map<String, Object> updateK8sNamespace(User loginUser, int id, String
userName);
Review Comment:
## Useless parameter
The parameter 'userName' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3506)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
