SbloodyS commented on code in PR #15024:
URL:
https://github.com/apache/dolphinscheduler/pull/15024#discussion_r1358276558
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java:
##########
@@ -100,7 +100,7 @@ public AlertResult send(String msg) {
} catch (Exception e) {
log.error("send http alert msg exception : {}", e.getMessage());
alertResult.setStatus("false");
- alertResult.setMessage("send http request alert fail.");
+ alertResult.setMessage("send http request alert fail." +
e.getMessage());
Review Comment:
```suggestion
alertResult.setMessage("send http request alert fail:" +
e.getMessage());
```
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/MailSender.java:
##########
@@ -405,7 +405,7 @@ public void deleteFile(File file) {
*/
private void handleException(AlertResult alertResult, Exception e) {
log.error("Send email to {} failed", receivers, e);
- alertResult.setMessage("Send email to {" + String.join(",", receivers)
+ "} failed，" + e.toString());
+ alertResult.setMessage("Send email to {" + String.join(",", receivers)
+ "} failed，" + e.getMessage());
Review Comment:
```suggestion
alertResult.setMessage("Send email to {" + String.join(",",
receivers) + "} failed:" + e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
