github-advanced-security[bot] commented on code in PR #15079: URL: https://github.com/apache/dolphinscheduler/pull/15079#discussion_r1372464965
########## dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-prometheus/src/main/java/org/apache/dolphinscheduler/plugin/alert/prometheus/AlertManagerSender.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.alert.prometheus; + +import org.apache.dolphinscheduler.alert.api.AlertData; +import org.apache.dolphinscheduler.alert.api.AlertResult; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + +import org.apache.commons.collections4.CollectionUtils; +import org.apache.http.HttpEntity; +import org.apache.http.HttpStatus; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.entity.ContentType; +import org.apache.http.entity.StringEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; + +import java.io.IOException; +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +import lombok.extern.slf4j.Slf4j; + +@Slf4j +public class AlertManagerSender { + + private String url; + private String generatorURL; + private String annotations; + + public AlertManagerSender(Map<String, String> config) { + url = config.get(AlertManagerConstants.NAME_ALERT_MANAGER_URL); + generatorURL = config.get(AlertManagerConstants.NAME_GENERATOR_URL); + annotations = config.get(AlertManagerConstants.NAME_ALERT_MANAGER_ANNOTATIONS); + } + + public AlertResult sendMessage(AlertData alertData) { + AlertResult alertResult; + try { + String resp = sendMsg(alertData); + return checkSendAlertManageMsgResult(resp); + } catch (Exception e) { + log.info("send prometheus alert manager alert msg exception: {}", e.getMessage()); + alertResult = new AlertResult(); + alertResult.setStatus("false"); + alertResult.setMessage("send prometheus alert manager alert fail."); + } + return alertResult; + } + + private String sendMsg(AlertData alertData) throws IOException { + String url = String.format("%s%s", this.url, AlertManagerConstants.ALERT_V2_API_PATH); + String msg = generateContentJson(alertData); + HttpPost httpPost = constructHttpPost(url, msg); + CloseableHttpClient httpClient = getDefaultClient(); + + try { + CloseableHttpResponse response = httpClient.execute(httpPost); + String resp; + int statusCode = response.getStatusLine().getStatusCode(); + if (statusCode == HttpStatus.SC_OK) { + resp = AlertManagerConstants.ALERT_SUCCESS; + log.info("Prometheus alert manager send alert succeed, title: {} ,content: {}", alertData.getTitle(), + alertData.getContent()); + return resp; + } + + log.error("send prometheus alert manager message error, return http status code: {} ", statusCode); + try { + HttpEntity entity = response.getEntity(); + resp = EntityUtils.toString(entity, "utf-8"); + EntityUtils.consume(entity); + } finally { + response.close(); + } + log.info("Prometheus alert manager send alert failed, title: {} ,content: {}, resp: {}", + alertData.getTitle(), + alertData.getContent(), resp); + + return resp; + } finally { + httpClient.close(); + } + } + + public AlertResult checkSendAlertManageMsgResult(String resp) { + AlertResult alertResult = new AlertResult(); + alertResult.setStatus("false"); + + if (Objects.equals(resp, AlertManagerConstants.ALERT_SUCCESS)) { + alertResult.setStatus("true"); + alertResult.setMessage("prometheus alert manager send success"); + return alertResult; + } + + alertResult.setMessage("prometheus alert manager send fail"); + log.info("send prometheus alert manager msg error,resp error"); + return alertResult; + } + + public String generateContentJson(AlertData alertData) { + List<HashMap> list = JSONUtils.toList(alertData.getContent(), HashMap.class); + HashMap<String, String> labels = new HashMap<>(); + if (CollectionUtils.isEmpty(list)) { + labels.put("content", alertData.getContent()); + } + for (Map map : list) { + for (Map.Entry<String, Object> entry : (Iterable<Map.Entry<String, Object>>) map.entrySet()) { + String key = entry.getKey(); + String value = entry.getValue().toString(); + labels.put(key, value); + } + } + labels.put("title", alertData.getTitle()); + + Map<String, Object> alert = new HashMap<>(); + alert.put("labels", labels); + + Map<String, String> annotations = JSONUtils.toMap(this.annotations); + if (annotations != null) { + alert.put("annotations", annotations); + } + + String formattedTime = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").format(new Date()); + alert.put("startsAt", formattedTime); + alert.put("endsAt", formattedTime); + + if (generatorURL != null && !generatorURL.equals("")) { Review Comment: ## Inefficient empty string test Inefficient comparison to empty string, check for zero length instead. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/3537) ########## dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-prometheus/src/main/java/org/apache/dolphinscheduler/plugin/alert/prometheus/AlertManagerSender.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.alert.prometheus; + +import org.apache.dolphinscheduler.alert.api.AlertData; +import org.apache.dolphinscheduler.alert.api.AlertResult; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + +import org.apache.commons.collections4.CollectionUtils; +import org.apache.http.HttpEntity; +import org.apache.http.HttpStatus; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.entity.ContentType; +import org.apache.http.entity.StringEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; + +import java.io.IOException; +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +import lombok.extern.slf4j.Slf4j; + +@Slf4j +public class AlertManagerSender { + + private String url; + private String generatorURL; + private String annotations; + + public AlertManagerSender(Map<String, String> config) { + url = config.get(AlertManagerConstants.NAME_ALERT_MANAGER_URL); + generatorURL = config.get(AlertManagerConstants.NAME_GENERATOR_URL); + annotations = config.get(AlertManagerConstants.NAME_ALERT_MANAGER_ANNOTATIONS); + } + + public AlertResult sendMessage(AlertData alertData) { + AlertResult alertResult; + try { + String resp = sendMsg(alertData); + return checkSendAlertManageMsgResult(resp); + } catch (Exception e) { + log.info("send prometheus alert manager alert msg exception: {}", e.getMessage()); + alertResult = new AlertResult(); + alertResult.setStatus("false"); + alertResult.setMessage("send prometheus alert manager alert fail."); + } + return alertResult; + } + + private String sendMsg(AlertData alertData) throws IOException { + String url = String.format("%s%s", this.url, AlertManagerConstants.ALERT_V2_API_PATH); Review Comment: ## Possible confusion of local and field Potentially confusing name: method [sendMsg](1) also refers to field [url](2) (as this.url). [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/3538) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
