xdu-chenrj commented on PR #15116: URL: https://github.com/apache/dolphinscheduler/pull/15116#issuecomment-1793976061
> > we need to fix all tasks that use the k8s namespace, such as the Spark task. i didn't get what you meant before. i just looked at some parameters required to create the Spark task. the namespace selected for the previous spark task was created in the cluster management of the security center. now, the Spark task needs to select the k8s connection created in the connection center. we need to refactor other tasks that use the k8s namespace, just like we refactor the k8s task, what do you think? > > For Spark on K8S, `connectionParams` in `k8sTaskExecutionContext` is null, cuz `k8sTaskExecutionContext` is constructed in Master, and don't set any value during construction which will cause NPE. > > ```java > k8sTaskExecutionContext > .setConfigYaml(JSONUtils.getNodeString(k8sTaskExecutionContext.getConnectionParams(), "kubeConfig")); > ``` I have made this modification to the current code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
