sdhzwc commented on code in PR #15144:
URL:
https://github.com/apache/dolphinscheduler/pull/15144#discussion_r1386289504
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskInstanceServiceImpl.java:
##########
@@ -258,6 +258,7 @@ public Result forceTaskSuccess(User loginUser, long
projectCode, Integer taskIns
// change the state of the task instance
task.setState(TaskExecutionStatus.FORCED_SUCCESS);
+ task.setEndTime(new Date());
Review Comment:
> Could u plz add a corresponding unit test case to cover this patch? Thanks
Forced success only results in a lack of end time, which prevents the
runtime from terminating,I don't think this unit test is necessary，Thanks : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
