Re: [PR] [Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. [dolphinscheduler]

[via GitHub]

qifanlili commented on code in PR #15139:
URL: 
https://github.com/apache/dolphinscheduler/pull/15139#discussion_r1387433757


##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/JdbcRegistryConfiguration.java:
##########
@@ -34,7 +34,7 @@
 @ConditionalOnProperty(prefix = "registry", name = "type", havingValue = 
"jdbc")
 public class JdbcRegistryConfiguration {
 
-    @Bean
+    @Bean("sqlSessionFactory")

Review Comment:
   > > It's not a good idea add name 'sqlSessionFactory' for this bean, since 
this will cause the JdbcRegistry use the same sql session factory with the 
business.
   > 
   > Thank you for reminding me of this. I write this because I find that When 
I  using `JDBCRegistry plugin`,
    if I don't explicitly declare 'sqlSessionFactory' , an exception will be 
thrown at startup: 
[dolphinscheduler-standalone.log](https://github.com/apache/dolphinscheduler/files/13303243/dolphinscheduler-standalone.log)
 <img alt="image" width="1106" 
src="https://user-images.githubusercontent.com/40498606/281602379-e26c6a96-4dfa-415e-ba99-2c1b618850a9.png";>
   > 
   > I think it might be because of 'DaoConfiguration. java 'references it <img 
alt="image" width="972" 
src="https://user-images.githubusercontent.com/40498606/281602082-803b41ea-d4c7-4cf1-b72a-0e52243e2588.png";>
   > 
   > Is this a known problem?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org