destroydestiny commented on PR #15153:
URL:
https://github.com/apache/dolphinscheduler/pull/15153#issuecomment-1807536052
> LGTM BTW, do we need to do some mapping ? as following :
>
> ```
> @Bean
> public DatabaseIdProvider databaseIdProvider() {
> VendorDatabaseIdProvider databaseIdProvider = new
VendorDatabaseIdProvider();
> Properties properties = new Properties();
> properties.put("Oracle","oracle");
> properties.put("MySQL","mysql");
> properties.put("PostgreSQL","pg");
> databaseIdProvider.setProperties(properties);
> return databaseIdProvider;
> }
> ```
>
> cc @EricGao888
Thank you for your review. I have made changes to the current code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
