ruanwenjun commented on code in PR #15163:
URL:
https://github.com/apache/dolphinscheduler/pull/15163#discussion_r1396708556
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java:
##########
@@ -352,4 +361,40 @@ private boolean checkHasAssociatedAlertGroup(String id) {
return first.isPresent();
}
+ @Override
+ public Result<Object> testSend(int pluginDefineId, String
pluginInstanceParams) {
+ Result<Object> result = new Result<>();
+ Optional<Host> alertServerAddressOptional =
registryClient.getAlertServerAddress();
+ if (!alertServerAddressOptional.isPresent()) {
+ log.error("Cannot get alert server address, please check the alert
server is running");
+ putMsg(result, Status.ALERT_CHANNEL_NOT_EXIST);
Review Comment:
Alert server not exist
##########
docs/img/new_ui/dev/alert/alert_instance01.png:
##########
Review Comment:
Why change these pictures?
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java:
##########
@@ -352,4 +361,40 @@ private boolean checkHasAssociatedAlertGroup(String id) {
return first.isPresent();
}
+ @Override
+ public Result<Object> testSend(int pluginDefineId, String
pluginInstanceParams) {
Review Comment:
```suggestion
public Result<Void> testSend(int pluginDefineId, String
pluginInstanceParams) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
