Gallardot commented on code in PR #15264:
URL:
https://github.com/apache/dolphinscheduler/pull/15264#discussion_r1412820845
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/TaskOutputParameterParser.java:
##########
@@ -36,46 +36,66 @@
@NotThreadSafe
public class TaskOutputParameterParser {
- private final Map<String, String> taskOutputParams = new HashMap<>();
+ // Used to avoid '${setValue(' which loss the end of ')}'
+ private final int maxOneParameterRows;
+
+ private final Map<String, String> taskOutputParams;
private List<String> currentTaskOutputParam;
- public void appendParseLog(String log) {
- if (log == null) {
+ public TaskOutputParameterParser() {
+ // the default max rows of one parameter is 1024, this should be enough
+ this(1024);
Review Comment:
Not only should the number of lines be limited, but the overall size should
also be restricted. For example, even a single line with excessively long
content could potentially lead to OOM issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
