SbloodyS commented on code in PR #11677:
URL:
https://github.com/apache/dolphinscheduler/pull/11677#discussion_r1417106870
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java:
##########
@@ -81,7 +81,7 @@ IPage<TaskInstance>
queryTaskInstanceListPaging(IPage<TaskInstance> page,
* @param endTime endTime
* @return task instance
*/
- TaskInstance queryLastTaskInstance(@Param("taskCode") long taskCode,
@Param("startTime") Date startTime, @Param("endTime") Date endTime);
+ TaskInstance queryLastTaskInstance(@Param("taskCode") long taskCode,
@Param("processInstanceId") long processInstanceId);
Review Comment:
> Yes, I understand. usually data processing is required to be completed on
the same day, but there are other tasks that need to be performed continuously
every day and not sensitive to date delays. upstream data may have acceptable
latency, when the delayed data is released, we usually expect the scheduling
platform to automatically and continuously process the delayed data (including
tasks that are blocked downstream for many days), especially when some
third-party data access is involved.
>
> Some scheduling platforms have the feature of automatic date flop of
tasks, especially this feature can also be implemented through the `dependent
task` of Dolphinscheduler, `system.biz.date` parameter can make sure the task
can get the correct date, dependent task(depend self yesterday) can make sure
the task runs in date continuously.
>
> and most important is, this update changed some rules, that can never use
`complement` command to rerun the delayed process which include `dependent
task`(it never worked with complement).
I'm +1 on this. Would you like to resubmit this pr to 2.0.9-prepare branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
