caishunfeng commented on code in PR #15355:
URL:
https://github.com/apache/dolphinscheduler/pull/15355#discussion_r1435527242
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql:
##########
@@ -73,4 +73,7 @@ END;
d//
delimiter ;
CALL modify_data_value_t_ds_dq_rule_input_entry;
-DROP PROCEDURE modify_data_value_t_ds_dq_rule_input_entry;
\ No newline at end of file
+DROP PROCEDURE modify_data_value_t_ds_dq_rule_input_entry;
+
+DROP TABLE IF EXISTS `t_ds_resources`;
+DROP TABLE IF EXISTS `t_ds_relation_resources_user`;
Review Comment:
This is a dangerous and irreversible operation, I don't think it should be
added in ddl.
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java:
##########
@@ -625,46 +623,6 @@ public Result deleteUdfFunc(@Parameter(hidden = true)
@RequestAttribute(value =
return udfFuncService.delete(loginUser, udfFuncId);
}
- /**
- * authorized file resource list
- *
- * @param loginUser login user
- * @param userId user id
- * @return authorized result
- */
- @Operation(summary = "authorizedFile", description =
"AUTHORIZED_FILE_NOTES")
- @Parameters({
- @Parameter(name = "userId", description = "USER_ID", required =
true, schema = @Schema(implementation = int.class, example = "100"))
- })
- @GetMapping(value = "/authed-file")
- @ResponseStatus(HttpStatus.CREATED)
- @ApiException(AUTHORIZED_FILE_RESOURCE_ERROR)
- public Result authorizedFile(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
Review Comment:
Should change the ui together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
