caishunfeng commented on code in PR #15362:
URL:
https://github.com/apache/dolphinscheduler/pull/15362#discussion_r1436681891
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java:
##########
@@ -163,23 +163,26 @@ public void validate(Object target, Errors errors) {
}
private void printConfig() {
- log.info("Master config: listenPort -> {} ", listenPort);
- log.info("Master config: fetchCommandNum -> {} ", fetchCommandNum);
- log.info("Master config: preExecThreads -> {} ", preExecThreads);
- log.info("Master config: execThreads -> {} ", execThreads);
- log.info("Master config: dispatchTaskNumber -> {} ",
dispatchTaskNumber);
- log.info("Master config: hostSelector -> {} ", hostSelector);
- log.info("Master config: heartbeatInterval -> {} ", heartbeatInterval);
- log.info("Master config: taskCommitRetryTimes -> {} ",
taskCommitRetryTimes);
- log.info("Master config: taskCommitInterval -> {} ",
taskCommitInterval);
- log.info("Master config: stateWheelInterval -> {} ",
stateWheelInterval);
- log.info("Master config: maxCpuLoadAvg -> {} ", maxCpuLoadAvg);
- log.info("Master config: reservedMemory -> {} ", reservedMemory);
- log.info("Master config: failoverInterval -> {} ", failoverInterval);
- log.info("Master config: killApplicationWhenTaskFailover -> {} ",
killApplicationWhenTaskFailover);
- log.info("Master config: registryDisconnectStrategy -> {} ",
registryDisconnectStrategy);
- log.info("Master config: masterAddress -> {} ", masterAddress);
- log.info("Master config: masterRegistryPath -> {} ",
masterRegistryPath);
- log.info("Master config: workerGroupRefreshInterval -> {} ",
workerGroupRefreshInterval);
+ String config = "\n****************************Master
Configuration**************************************";
Review Comment:
Is it better to use `StringBuilder`?
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java:
##########
@@ -327,45 +303,13 @@ private TaskConstants() {
*/
public static final String D = "-D";
- /**
- * jdbc url
- */
- public static final String JDBC_MYSQL = "jdbc:mysql://";
- public static final String JDBC_POSTGRESQL = "jdbc:postgresql://";
- public static final String JDBC_HIVE_2 = "jdbc:hive2://";
- public static final String JDBC_CLICKHOUSE = "jdbc:clickhouse://";
- public static final String JDBC_DATABEND = "jdbc:databend://";
- public static final String JDBC_ORACLE_SID = "jdbc:oracle:thin:@";
- public static final String JDBC_ORACLE_SERVICE_NAME =
"jdbc:oracle:thin:@//";
- public static final String JDBC_SQLSERVER = "jdbc:sqlserver://";
- public static final String JDBC_DB2 = "jdbc:db2://";
- public static final String JDBC_PRESTO = "jdbc:presto://";
-
- /**
- * driver
- */
- public static final String ORG_POSTGRESQL_DRIVER = "org.postgresql.Driver";
- public static final String COM_MYSQL_CJ_JDBC_DRIVER =
"com.mysql.cj.jdbc.Driver";
- public static final String ORG_APACHE_HIVE_JDBC_HIVE_DRIVER =
"org.apache.hive.jdbc.HiveDriver";
- public static final String COM_CLICKHOUSE_JDBC_DRIVER =
"com.clickhouse.jdbc.ClickHouseDriver";
- public static final String COM_DATABEND_JDBC_DRIVER =
"com.databend.jdbc.DatabendDriver";
- public static final String COM_ORACLE_JDBC_DRIVER =
"oracle.jdbc.driver.OracleDriver";
- public static final String COM_SQLSERVER_JDBC_DRIVER =
"com.microsoft.sqlserver.jdbc.SQLServerDriver";
- public static final String COM_DB2_JDBC_DRIVER =
"com.ibm.db2.jcc.DB2Driver";
- public static final String COM_PRESTO_JDBC_DRIVER =
"com.facebook.presto.jdbc.PrestoDriver";
Review Comment:
Don't need these constant anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
