ruanwenjun commented on code in PR #15367:
URL:
https://github.com/apache/dolphinscheduler/pull/15367#discussion_r1436717540
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/AbstractDataSourceProcessor.java:
##########
@@ -128,4 +130,9 @@ public boolean checkDataSourceConnectivity(ConnectionParam
connectionParam) {
return false;
}
}
+
+ @Override
+ public List<String> splitAndRemoveComment(String sql) {
Review Comment:
Done. Add some UT case for Oracle, Dorid, Mysql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
