Gallardot commented on code in PR #15439:
URL:
https://github.com/apache/dolphinscheduler/pull/15439#discussion_r1444202490
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -506,10 +506,15 @@ master:
MASTER_TASK_COMMIT_INTERVAL: "1s"
# -- master state wheel interval, the unit is second
MASTER_STATE_WHEEL_INTERVAL: "5s"
- # -- Master max cpuload avg, only higher than the system cpu load average,
master server can schedule
- MASTER_MAX_CPU_LOAD_AVG: "1"
- # -- Master reserved memory, only lower than system available memory,
master server can schedule, the unit is G
- MASTER_RESERVED_MEMORY: "0.3"
+ MASTER_SERVER_LOAD_PROTECTION_ENABLED: true
+ # Master max cpu usage, when the master's cpu usage is smaller then this
value, master server can execute workflow.
+ MASTER_SERVER_LOAD_PROTECTION_MAX_CPU_USAGE_PERCENTAGE_THRESHOLDS: 0.7
+ # Master max JVM memory usage , when the master's jvm memory usage is
smaller then this value, master server can execute workflow.
Review Comment:
```suggestion
# -- Master max JVM memory usage , when the master's jvm memory usage is
smaller then this value, master server can execute workflow.
```
Similarly, comments for newly added parameters in `values.yaml` need to be
modified.
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -506,10 +506,15 @@ master:
MASTER_TASK_COMMIT_INTERVAL: "1s"
# -- master state wheel interval, the unit is second
MASTER_STATE_WHEEL_INTERVAL: "5s"
- # -- Master max cpuload avg, only higher than the system cpu load average,
master server can schedule
- MASTER_MAX_CPU_LOAD_AVG: "1"
- # -- Master reserved memory, only lower than system available memory,
master server can schedule, the unit is G
- MASTER_RESERVED_MEMORY: "0.3"
+ MASTER_SERVER_LOAD_PROTECTION_ENABLED: true
+ # Master max cpu usage, when the master's cpu usage is smaller then this
value, master server can execute workflow.
Review Comment:
```suggestion
# -- Master max cpu usage, when the master's cpu usage is smaller then
this value, master server can execute workflow.
```
Refer to [helm-docs](https://github.com/norwoodj/helm-docs), comments need
to be added with -- for them to be recognized, then they will be automatically
updated to README.md by helm-docs.
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -506,10 +506,15 @@ master:
MASTER_TASK_COMMIT_INTERVAL: "1s"
# -- master state wheel interval, the unit is second
MASTER_STATE_WHEEL_INTERVAL: "5s"
- # -- Master max cpuload avg, only higher than the system cpu load average,
master server can schedule
- MASTER_MAX_CPU_LOAD_AVG: "1"
- # -- Master reserved memory, only lower than system available memory,
master server can schedule, the unit is G
- MASTER_RESERVED_MEMORY: "0.3"
+ MASTER_SERVER_LOAD_PROTECTION_ENABLED: true
Review Comment:
Lack of comments
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -506,10 +506,15 @@ master:
MASTER_TASK_COMMIT_INTERVAL: "1s"
# -- master state wheel interval, the unit is second
MASTER_STATE_WHEEL_INTERVAL: "5s"
- # -- Master max cpuload avg, only higher than the system cpu load average,
master server can schedule
- MASTER_MAX_CPU_LOAD_AVG: "1"
- # -- Master reserved memory, only lower than system available memory,
master server can schedule, the unit is G
- MASTER_RESERVED_MEMORY: "0.3"
+ MASTER_SERVER_LOAD_PROTECTION_ENABLED: true
Review Comment:
If deployed through k8s, this default value should be able to be set to
false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
