zhongjiajie commented on code in PR #133:
URL: 
https://github.com/apache/dolphinscheduler-sdk-python/pull/133#discussion_r1451638182


##########
src/pydolphinscheduler/examples/tutorial.py:
##########
@@ -49,7 +48,17 @@
     # [end workflow_declare]
     # [start task_declare]
     task_parent = Shell(name="task_parent", command="echo hello 
pydolphinscheduler")
-    task_child_one = Shell(name="task_child_one", command="echo 'child one'")
+    task_child_one = Shell(
+        name="task_child_one",
+        command="""
+        echo "Executing line 1 for {param1}"
+        echo "Executing line 2 for {param2}"
+        echo "Executing line 3 for {param3}"
+        """.format(
+            param1="child one", param2="parameter two", param3="parameter 
three"
+        ),
+        params={"param1": "value1", "param2": "value2", "param3": "value3"},

Review Comment:
   ```suggestion
           command="""
           echo "Executing line 1 with parameter str type ${param1}"
           echo "Executing line 2 with parameter int type ${param2}"
           echo "Executing line 3 with parameter build-in parameter currently 
date ${param3}"
           """,
           params={"param1": "str1", "param2": 123, "param3": "$[yyyy-MM-dd]"},
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to