ruanwenjun commented on code in PR #15277:
URL:
https://github.com/apache/dolphinscheduler/pull/15277#discussion_r1467273178
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ILogicTask.java:
##########
@@ -31,4 +34,7 @@ public interface ILogicTask {
TaskExecutionContext getTaskExecutionContext();
+ default List<Property> getVarPool() {
+ return getTaskParameters().getVarPool();
+ }
Review Comment:
I don't agree we need to add this method in `ILogicTask`, the Task SPI
doesn't need to add this method, otherwise we need to add a lot of get method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
