alei1206 commented on PR #15459: URL: https://github.com/apache/dolphinscheduler/pull/15459#issuecomment-1911570921
> Does anyone see the `todo` here? Why only handle the delete event, in fact this is not a bug, the task dispatch failed it will retry until the master refresh worker node, in this PR only handle the delete event, but still miss add event is not a good pr. @ruanwenjun Hi, I think, when master refresh worker node， only add new worker server to cache, but not delete the offline worker。 if we not handle the delete event, the offline worker server are always in the cache. Additionally, `updateWorkerNodes()` will get all the worker nodes in zk and add them to the cache, so I think, we shouldn't need to handle the add event.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
