pegasas commented on code in PR #15534:
URL:
https://github.com/apache/dolphinscheduler/pull/15534#discussion_r1470460103
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -72,7 +72,7 @@ $ DOLPHINSCHEDULER_VERSION=<version>
# Initialize the database, make sure database <DATABASE> already exists
$ docker run -d --name dolphinscheduler-tools \
-e DATABASE="postgresql" \
- -e SPRING_DATASOURCE_URL="jdbc:postgresql://localhost:5432/<DATABASE>" \
+ -e
SPRING_DATASOURCE_URL="jdbc:postgresql://localhost:5432/dolphinscheduler" \
Review Comment:
So I think maybe we should correct below 4 into DATABASE?
I think we should all changed to dolphinscheduler or <DATABASE>.
or else it is confusing.
It is also a little bit confuse with SPRING_DATABASE configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]