This is an automated email from the ASF dual-hosted git repository.
changhaifu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 718a01bb42 [Improvement][UT] Add UT for end time check when force
success task (#15562)
718a01bb42 is described below
commit 718a01bb429baedffa8f394e121d5c6e01599406
Author: Rick Cheng <[email protected]>
AuthorDate: Thu Feb 8 09:19:56 2024 +0800
[Improvement][UT] Add UT for end time check when force success task (#15562)
---
.../apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
index b537c06dda..aca0d80a6f 100644
---
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
+++
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
@@ -343,7 +343,7 @@ public class TaskInstanceServiceTest {
}
@Test
- public void forceTaskSuccess() {
+ public void testForceTaskSuccess() {
User user = getAdminUser();
long projectCode = 1L;
Project project = getProject(projectCode);
@@ -392,12 +392,14 @@ public class TaskInstanceServiceTest {
// test success
task.setState(TaskExecutionStatus.FAILURE);
+ task.setEndTime(null);
when(taskInstanceMapper.updateById(task)).thenReturn(1);
putMsg(result, Status.SUCCESS, projectCode);
when(projectMapper.queryByCode(projectCode)).thenReturn(project);
when(projectService.checkProjectAndAuth(user, project, projectCode,
FORCED_SUCCESS)).thenReturn(result);
Result successRes = taskInstanceService.forceTaskSuccess(user,
projectCode, taskId);
Assertions.assertEquals(Status.SUCCESS.getCode(),
successRes.getCode().intValue());
+ Assertions.assertNotNull(task.getEndTime());
}