(dolphinscheduler) branch dev updated: [Improvement][API] add PageInfo UT (#15622)

[zihaoxiang]

This is an automated email from the ASF dual-hosted git repository.

zihaoxiang pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new b278df1311 [Improvement][API] add PageInfo UT (#15622)
b278df1311 is described below

commit b278df131174664726f4360bb58c7bdeb4e3ff64
Author: Gallardot <gallar...@apache.org>
AuthorDate: Mon Feb 26 15:24:32 2024 +0800

    [Improvement][API] add PageInfo UT (#15622)
    
    Signed-off-by: Gallardot <gallar...@apache.org>
    Co-authored-by: xiangzihao <460888...@qq.com>
---
 .../dolphinscheduler/api/utils/PageInfo.java       |  2 +-
 .../dolphinscheduler/api/utils/PageInfoTest.java   | 48 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 1 deletion(-)

diff --git 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
index 53bed34039..2cfdd8f840 100644
--- 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
+++ 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
@@ -80,7 +80,7 @@ public class PageInfo<T> {
 
     public Integer getTotalPage() {
         if (pageSize == null || pageSize == 0) {
-            pageSize = 7;
+            pageSize = 10;
         }
         this.totalPage =
                 (this.total % this.pageSize) == 0
diff --git 
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/PageInfoTest.java
 
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/PageInfoTest.java
new file mode 100644
index 0000000000..78cbb838fb
--- /dev/null
+++ 
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/PageInfoTest.java
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.api.utils;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class PageInfoTest {
+
+    @Test
+    public void testGetTotalPageWhenTotalAndPageSizeArePositive() {
+        PageInfo<Object> pageInfo = new PageInfo<>();
+        pageInfo.setTotal(100);
+        pageInfo.setPageSize(20);
+        Assertions.assertEquals(5, pageInfo.getTotalPage());
+    }
+
+    @Test
+    public void testGetTotalPageWhenTotalIsZero() {
+        PageInfo<Object> pageInfo = new PageInfo<>();
+        pageInfo.setTotal(0);
+        pageInfo.setPageSize(20);
+        Assertions.assertEquals(1, pageInfo.getTotalPage());
+    }
+
+    @Test
+    public void testGetTotalPageWhenPageSizeIsZero() {
+        PageInfo<Object> pageInfo = new PageInfo<>();
+        pageInfo.setTotal(101);
+        pageInfo.setPageSize(0);
+        Assertions.assertEquals(11, pageInfo.getTotalPage());
+    }
+}