ruanwenjun commented on code in PR #15652:
URL: 
https://github.com/apache/dolphinscheduler/pull/15652#discussion_r1507419008


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java:
##########
@@ -182,10 +165,7 @@ private String getFullName(String currentDir, String name) 
{
      */
     @Override
     @Transactional
-    public Result<Object> createResource(User loginUser,
-                                         String name,
-                                         ResourceType type,
-                                         MultipartFile file,
+    public Result<Object> uploadResource(User loginUser, String name, 
ResourceType type, MultipartFile file,

Review Comment:
   DS will throw exception when the user want to modify the system file which 
is not under resource path by update content API.  This can help to protect the 
system.
   
   The upload API will not be affected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to