github-advanced-security[bot] commented on code in PR #15681:
URL:
https://github.com/apache/dolphinscheduler/pull/15681#discussion_r1515705791
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -815,6 +815,13 @@
return result;
}
+ /**
+ * Check if there're any tasks that depend on the process
+ */
+ private void checkIfDependentTaskExists(ProcessDefinition
processDefinition) {
Review Comment:
## Useless parameter
The parameter 'processDefinition' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3935)
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/WorkFlowLineageService.java:
##########
@@ -45,6 +45,16 @@
*/
Set<TaskMainInfo> queryTaskDepOnProcess(long projectCode, long
processDefinitionCode);
+ /**
+ * Query downstream tasks depend on a process definition or a task
+ *
+ * @param projectCode Project code want to query tasks dependence
+ * @param processDefinitionCode Process definition code want to query
tasks dependence
+ * @param taskCode Task code want to query tasks dependence
+ * @return downstream dependent tasks
+ */
+ Map<String, Object> queryDownstreamDependentTasks(Long projectCode, Long
processDefinitionCode, Long taskCode);
Review Comment:
## Useless parameter
The parameter 'projectCode' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3934)
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkFlowLineageController.java:
##########
@@ -135,4 +135,26 @@
putMsg(result, Status.SUCCESS);
return result;
}
+
+ @Operation(summary = "queryDownstreamDependentTaskList", description =
"QUERY_DOWNSTREAM_DEPENDENT_TASK_NOTES")
+ @Parameters({
+ @Parameter(name = "projectCode", description = "PROJECT_CODE",
required = true, schema = @Schema(implementation = Long.class)),
+ @Parameter(name = "workFlowCode", description =
"PROCESS_DEFINITION_CODE", required = true, schema = @Schema(implementation =
Long.class)),
+ @Parameter(name = "taskCode", description =
"TASK_DEFINITION_CODE", required = false, schema = @Schema(implementation =
Long.class, example = "123456789")),
+ })
+ @GetMapping(value = "/query-dependent-tasks")
+ @ResponseStatus(HttpStatus.OK)
+ public Result<Map<String, Object>>
queryDownstreamDependentTaskList(@Parameter(hidden = true)
@RequestAttribute(value = SESSION_USER) User loginUser,
Review Comment:
## Useless parameter
The parameter 'loginUser' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3933)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
