rickchengx commented on code in PR #15628:
URL:
https://github.com/apache/dolphinscheduler/pull/15628#discussion_r1517340687
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java:
##########
@@ -156,7 +156,6 @@ public void kill(String taskId) throws IOException {
String pid = getTaskPid(taskId);
String killCommand = String.format(COMMAND.KILL_COMMAND, pid);
runRemote(killCommand);
- cleanData(taskId);
Review Comment:
> @rickchengx Hi, I read the logic again, we can not delete `cleanData()
`here. I think, The `rm` command in `cleanData()` should be replaced to `rm -f`
to avoid the printing of the error log when the file is not existed. what you
think?
I think we should make sure the remote task can be killed successfully. And
There can be various reasons for errors when cleaning data, and I think it's
acceptable to make users aware of these errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
