ZhongJinHacker opened a new issue, #15688:
URL: https://github.com/apache/dolphinscheduler/issues/15688

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   ```java
       public void removeWorkerNodePath(String path, RegistryNodeType nodeType, 
boolean failover) {
           log.info("{} node deleted : {}", nodeType, path);
           try {
               String serverHost = null;
               if (!StringUtils.isEmpty(path)) {
                   serverHost = registryClient.getHostByEventDataPath(path);
                   if (StringUtils.isEmpty(serverHost)) {
                       log.error("server down error: unknown path: {}", path);
                       return;
                   }
                   if (!registryClient.exists(path)) {
                       log.info("path: {} not exists", path);
                   }
               }
               // failover server
               if (failover) {
                   failoverService.failoverServerWhenDown(serverHost, nodeType);
               }
           } catch (Exception e) {
               log.error("{} server failover failed", nodeType, e);
           }
       }
   ```
   When call `removeWorkerNodePath` , if its first param named path is null, it 
will cause `serverHost` is null.
   And it  is unacceptable when call `failoverService.failoverServerWhenDown`, 
because in `failoverServerWhenDown` method block , 
`masterFailoverService.failoverMaster` and 
`workerFailoverService.failoverWorker` had already been emphasized that 
serverHost cannot be NULL  by adding NonNull annotations
   
   
   ### What you expected to happen
   
   please assign this issue to me,  I'm glad to deal with this issue
   
   ### How to reproduce
   
   make the situation of the path is null or empty string, and call 
removeWorkerNodePath, it will happen.
   
    
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to