rickchengx commented on code in PR #15629:
URL: 
https://github.com/apache/dolphinscheduler/pull/15629#discussion_r1526016410


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtils.java:
##########
@@ -146,6 +147,32 @@ public static String getPidsStr(int processId) throws 
Exception {
         return sb.toString().trim();
     }
 
+    public static String parsePidStr(String rawPidStr) {

Review Comment:
   This function has some common logic with function `getPidsStr`. I think the 
common logic should be extracted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to