rickchengx commented on code in PR #15714:
URL:
https://github.com/apache/dolphinscheduler/pull/15714#discussion_r1527688961
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -162,7 +162,7 @@ public Result<Object> queryDataSource(@Parameter(hidden =
true) @RequestAttribut
@ApiException(QUERY_DATASOURCE_ERROR)
public Result<Object> queryDataSourceList(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@RequestParam("type") DbType
type) {
- List<DataSource> datasourceList =
dataSourceService.queryDataSourceList(loginUser, type.ordinal());
+ List<DataSource> datasourceList =
dataSourceService.queryDataSourceList(loginUser, type.getCode());
Review Comment:
overall LGTM, please update the related UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
