bajiaolong commented on code in PR #15708:
URL:
https://github.com/apache/dolphinscheduler/pull/15708#discussion_r1527939725
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskExecutionContext.java:
##########
@@ -172,12 +172,6 @@ public class TaskExecutionContext implements Serializable {
*/
private String environmentConfig;
- /**
- * definedParams
- * // todo: we need to rename definedParams, prepareParamsMap, paramsMap,
this is confusing
- */
- private Map<String, String> definedParams;
Review Comment:
> hi @bajiaolong `definedParams ` Is this parameter only used for Flink type
tasks?
In addition to `flink`, there are also `MapReduce` and `Pigeon` tasks in
use. But this parameter seems to have no effect, because I didn't see the task
place setting it. The `Pigeon` task has test cases, so I revised them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
