EricGao888 commented on code in PR #15752:
URL:
https://github.com/apache/dolphinscheduler/pull/15752#discussion_r1533680125
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSender.java:
##########
@@ -69,6 +69,11 @@ private AlertResult executeShellScript(String title, String
content) {
alertResult.setMessage("shell script not support windows os");
return alertResult;
}
+ if (!scriptPath.endsWith(".sh")) {
+ alertResult.setMessage("shell script is invalid, only support .sh
file");
Review Comment:
In that case, we have to deprecate this plugin in the future. I think users
tend to deploy a centralized alert server, which is different from worker and
makes the alert server more vulnerable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
