EricGao888 commented on code in PR #15751:
URL:
https://github.com/apache/dolphinscheduler/pull/15751#discussion_r1534976420
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/operator/BaseTaskExecuteRunnableDispatchOperator.java:
##########
@@ -48,9 +48,10 @@ public void operate(DefaultTaskExecuteRunnable
taskExecuteRunnable) {
if (remainTime > 0) {
taskInstance.setState(TaskExecutionStatus.DELAY_EXECUTION);
taskInstanceDao.updateById(taskInstance);
- log.info("Current taskInstance: {} is choose delay execution,
delay time: {}/s, remainTime: {}/s",
+ log.info("Current taskInstance: {} is choose delay execution,
delay time: {}/min, remainTime: {}/s",
Review Comment:
This looks a bit wired. Could we make the unit for delay time and remain
time consistent? (all in second / all in minute)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
