EricGao888 commented on code in PR #15758:
URL:
https://github.com/apache/dolphinscheduler/pull/15758#discussion_r1535745383
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/loop/template/http/parser/HttpTaskDefinitionParser.java:
##########
@@ -60,7 +60,7 @@
}
protected @NonNull LoopTaskYamlDefinition parseYamlConfigFile(@NonNull
String yamlConfigFile) throws IOException {
- Yaml yaml = new Yaml(new Constructor(LoopTaskYamlDefinition.class));
+ Yaml yaml = new Yaml(new SafeConstructor());
Review Comment:
In `package org.yaml.snakeyaml.constructor;`, we could see `public class
Constructor extends SafeConstructor`. Therefore I think there is no need to
change it.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/loop/template/http/parser/HttpTaskDefinitionParser.java:
##########
@@ -60,7 +60,7 @@
}
protected @NonNull LoopTaskYamlDefinition parseYamlConfigFile(@NonNull
String yamlConfigFile) throws IOException {
- Yaml yaml = new Yaml(new Constructor(LoopTaskYamlDefinition.class));
+ Yaml yaml = new Yaml(new SafeConstructor());
Review Comment:
@SbloodyS In `package org.yaml.snakeyaml.constructor;`, we could see `public
class Constructor extends SafeConstructor`. Therefore I think there is no need
to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
