qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547057095
########## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql: ########## @@ -2008,10 +2008,14 @@ DROP TABLE IF EXISTS `t_ds_audit_log`; CREATE TABLE `t_ds_audit_log` ( `id` bigint(11) NOT NULL AUTO_INCREMENT COMMENT'key', `user_id` int(11) NOT NULL COMMENT 'user id', - `resource_type` int(11) NOT NULL COMMENT 'resource type', - `operation` int(11) NOT NULL COMMENT 'operation', - `time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'create time', - `resource_id` int(11) NULL DEFAULT NULL COMMENT 'resource id', + `object_id` bigint(20) DEFAULT NULL COMMENT 'object id', + `object_name` varchar(100) DEFAULT NULL COMMENT 'object id', + `object_type` varchar(100) NOT NULL COMMENT 'object type', Review Comment: For this part, I defined object id means the object I modified, `task instance` it's not a module. `File `is not a domain, I think `object` is more suit for this, can cover all the stuff we record, WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
