pegasas commented on code in PR #15826: URL: https://github.com/apache/dolphinscheduler/pull/15826#discussion_r1560466904
########## dolphinscheduler-common/src/main/resources/remote-logging.properties: ########## @@ -0,0 +1,36 @@ +# Whether to enable remote logging Review Comment: > May I ask why not move these configs into `application.yaml`? do you mean application.yaml in api/master/worker? If so, we bind configuration loader mechanism binding to springboot. Also, maybe `application.yaml` configuration are all about spirngboot runtime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
