rickchengx commented on code in PR #15729:
URL:
https://github.com/apache/dolphinscheduler/pull/15729#discussion_r1562279361
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -250,6 +251,14 @@ public class ProcessDefinitionServiceImpl extends
BaseServiceImpl implements Pro
@Autowired
private ListenerEventAlertManager listenerEventAlertManager;
+ private static final int thresholdEntries = 10000;
+ private static final int thresholdSize = 1000000000; // 1 GB
+ private static final double thresholdRatio = 10;
+
+ private final Map<String, DataSource> dataSourceCache = new HashMap<>(1);
Review Comment:
These maps were originally local variables of method
`importSqlProcessDefinition`, but they are now private variables of the class,
which I think may cause problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
