(dolphinscheduler) branch dev updated: delete useless code (#15844)

[caishunfeng]

This is an automated email from the ASF dual-hosted git repository.

caishunfeng pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new efbffacfbe delete useless code (#15844)
efbffacfbe is described below

commit efbffacfbecd3632388e69ed400e3433ecc35f4a
Author: 旺阳 <w...@lqwang.net>
AuthorDate: Mon Apr 15 11:29:11 2024 +0800

    delete useless code (#15844)
---
 .../apache/dolphinscheduler/dao/mapper/UdfFuncMapper.java   |  7 -------
 .../apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml    | 12 ------------
 .../dolphinscheduler/dao/mapper/UdfFuncMapperTest.java      | 13 -------------
 3 files changed, 32 deletions(-)

diff --git 
a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.java
 
b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.java
index 6bc8049c7d..abc12f9aa1 100644
--- 
a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.java
+++ 
b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.java
@@ -109,13 +109,6 @@ public interface UdfFuncMapper extends BaseMapper<UdfFunc> 
{
      */
     List<UdfFunc> listAuthorizedUdfByResourceId(@Param("userId") int userId, 
@Param("resourceIds") int[] resourceIds);
 
-    /**
-     * batch update udf func
-     * @param udfFuncList  udf list
-     * @return update num
-     */
-    int batchUpdateUdfFunc(@Param("udfFuncList") List<UdfFunc> udfFuncList);
-
     /**
      * listAuthorizedUdfByUserId
      * @param userId
diff --git 
a/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml
 
b/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml
index 24cb8de956..84f9fd9708 100644
--- 
a/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml
+++ 
b/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml
@@ -171,18 +171,6 @@
             </foreach>
         </if>
     </select>
-    <update id="batchUpdateUdfFunc" parameterType="java.util.List">
-        <foreach collection="udfFuncList" item="udf" index="index" open="" 
close="" separator=";">
-            update t_ds_udfs
-            <set>
-                resource_name=#{udf.resourceName},
-                update_time=#{udf.updateTime}
-            </set>
-            <where>
-                id=#{udf.id}
-            </where>
-        </foreach>
-    </update>
 
     <select id="listAuthorizedUdfByUserId" 
resultType="org.apache.dolphinscheduler.dao.entity.UdfFunc">
         select
diff --git 
a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
 
b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
index 7744497826..5d04a022a7 100644
--- 
a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
+++ 
b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
@@ -25,7 +25,6 @@ import org.apache.dolphinscheduler.dao.entity.UDFUser;
 import org.apache.dolphinscheduler.dao.entity.UdfFunc;
 import org.apache.dolphinscheduler.dao.entity.User;
 
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.Date;
@@ -278,16 +277,4 @@ public class UdfFuncMapperTest extends BaseDaoTest {
         Assertions.assertTrue(authorizedUdfFunc.stream().map(t -> 
t.getId()).collect(toList())
                 .containsAll(Arrays.asList(udfFuncIds)));
     }
-
-    @Test
-    public void batchUpdateUdfFuncTest() {
-        // create general user
-        User generalUser1 = createGeneralUser("user1");
-        UdfFunc udfFunc = insertOne(generalUser1);
-        udfFunc.setResourceName("/updateTest");
-        List<UdfFunc> udfFuncList = new ArrayList<>();
-        udfFuncList.add(udfFunc);
-        Assertions.assertTrue(udfFuncMapper.batchUpdateUdfFunc(udfFuncList) > 
0);
-
-    }
 }