ruanwenjun opened a new issue, #15889:
URL: https://github.com/apache/dolphinscheduler/issues/15889

   ### Search before asking
   
   - [X] I had searched in the 
[DSIP](https://github.com/apache/dolphinscheduler/issues/14102) and found no 
similar DSIP.
   
   
   ### Motivation
   
   I am not clear why we set the hikari thread pool size, I don't find out any 
benchmark test result. 
   
   Following 
https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing, I hope to 
remove the configuration of hikari, the default setting is great enough. We 
shouldn't change the default setting unless we have benchmark evidence.
   
   
https://github.com/apache/dolphinscheduler/blob/e66441a2c9ec38387b34f3712055af7308876efc/dolphinscheduler-api/src/main/resources/application.yaml#L52-L62
   
   ### Design Detail
   
   Only keep the `pool name` and `connection-test-query`
       hikari:
         connection-test-query: select 1
         pool-name: DolphinScheduler
   
   ### Compatibility, Deprecation, and Migration Plan
   
   Compatible with all version.
   
   ### Test Plan
   
   Test by e2e.
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to