yangyichao-mango commented on pull request #2965: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2965#issuecomment-647135923
> What is the function of this ThreadLocal? Is it necessary? I think we changed our log format and implemented it with loggerutils Thx a lot for your review @dailidong . In my opinion, it's better to set the `tasklogger` threadlocal value to log the task detail but not to pass the `tasklogger` through the function's input params in the utils class of `FileUtils` and `OSUtils`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
